Skip to content

More cleanups to commits for issue #1393 #1537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

kevina
Copy link
Contributor

@kevina kevina commented Jan 16, 2012

The commits:

  1. Update the tutorial to document the new feature.
  2. Fix Need custom discriminant tests in the pretty printer #1510.
  3. Avoid evaluating discriminator value constants when parsing
  4. Correctly type checks the discriminator value as an integer

values set and that it is possible to cast them to scalar values.
Partly fixes issue rust-lang#1510.  "rustc --pretty=typed" fails.
Remove disr_val from ast::variant_ and always use ty::variant_info
when the value is needed.  Move what was done during parsing into
other passes, primary typeck.rs.  This move also correctly type checks
the disr. value expression; thus, fixing rustc --pretty=typed when
disr. values are used.
@marijnh
Copy link
Contributor

marijnh commented Jan 16, 2012

Merged. I had already picked 29eadc33186dd1dffd2813c2b220c1dff258eeac into my branch as I was working on #1532, so the order of the patches got shuffled around a bit.

@marijnh marijnh closed this Jan 16, 2012
kevina added a commit to kevina/rust that referenced this pull request Jan 17, 2012
Mostly updates to the comments and docs from Pull Request rust-lang#1537.
celinval pushed a commit to celinval/rust-dev that referenced this pull request Jun 4, 2024
)

* docs: add conc playback sub-section to getting started

* refactor: change exe-trace name in Kani flags

* refactor: initial change over to new flags

* refactor: change exe_trace in Kani lib

* more Kani lib name updates

* update feature flag in docs

* bunch more name changes

* change det val to concrete val

* fix wording

* update arg desc

* make output_filename_opt more clean

* more renaming

* more det renaming in kani lib

* address some of Celina's comments

* remove all the rename changes

* some more updates

* change tense from 'user' to 'you'

* make setup section more clear

* update doc structure to debug verif fails

* turn options into bullets

* add enable-unstable

* add example

* add to example

* add mode description to args

* add link to milestone
bjorn3 added a commit to bjorn3/rust that referenced this pull request Nov 2, 2024
Don't panic about debug info for Arm64 Windows unwind info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need custom discriminant tests in the pretty printer
2 participants